Maya look: skip empty file attributes #3274
Conversation
| if not source: | ||
| self.log.info("source is empty, skipping...") | ||
| continue |
There was a problem hiding this comment.
Would it be worth adding a comment in code to state why we'd sometimes want to skip collecting on a file node - as a reminder for our future selves.
Since technically with this change it also now allows a user to publish a look using a file node that doesn't have a texture set without that being validated against, yes?
There was a problem hiding this comment.
Doesnt Arnold throw an error if this happens? If so we should defo validate.
There was a problem hiding this comment.
I seems this is allowed only for Renderman as it seems. I can add logic just for that but I hate to have so much renderer specific codes....
There was a problem hiding this comment.
I'm not quite sure if it should be our responsibility to check if a file node is empty or not. I would just allow it across the board and leave it to the artist. It's way too wide of a problem to potentially deal with it for all renderers and their usecases.
There was a problem hiding this comment.
I've limited it to renderman nodes, I believe this is the safest and easiest approch to it
| @@ -601,6 +601,11 @@ def collect_resources(self, node): | |||
| source, | |||
| computed_source)) | |||
|
|
|||
| # renderman allows nodes to have filename attribute empty while | |||
| # you can have another incoming connection from different node. | |||
| if not source and cmds.nodeType(node).lower().startswith("pxr"): | |||
There was a problem hiding this comment.
There might be a better way to limit it to renderman nodes.
You could query the node types relevant to the Pixar Renderman plug-in and could check whether it's part of that plug-in?
E.g. here is how to do the same for Redshift node types:
from maya import cmds
redshift_node_types = set(cmds.pluginInfo("redshift4maya", query=True, dependNode=True))You'd need to first ensure the plug-in is available/loaded however but you can query against that too - but it might be more explicit than the string comparison?
Fix
This is fixing look collector so it will skip empty filename attributes. Useful mainly on nodes that defines file attribute but can accept also input from other nodes.
Testing
Create look with shader network, connecting PxrTexture to PxrBump for example in renderman (leaving filename attribute in PxrBump empty. Publishing and loading of the look should be successfull